Review Request: Add KDE CookieJar integration class to accessmanager.[h|cpp]

[Urs Wolfer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1711/#review2706
-----------------------------------------------------------



/branches/KDE/4.3/kdelibs/kio/kio/accessmanager.h
<http://reviewboard.kde.org/r/1711/#comment1988>

    IMHO there should be a deprecated info in the doc for the "old" naming. We already suggest to use the new one. A compiler deprecated warning will not work here because of the typedef...



/branches/KDE/4.3/kdelibs/kio/kio/accessmanager.cpp
<http://reviewboard.kde.org/r/1711/#comment1987>

    intended change?


- Urs


On 2009-10-18 20:59:49, adawit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1711/
> -----------------------------------------------------------
> 
> (Updated 2009-10-18 20:59:49)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This patch does the following:
> 
> * It adds a nested namespace, NetworkIntegtation, to delinate KIO classes intended to be used for KDE integration only.
> * It adds a new class, KIO::NetworkIntegration::CookieJar, that allows Qt modules like QtWebKit to use KDE's cookiejar.
> * It documents everything including a note about the intended usage of these classes.
> 
> 
> Diffs
> -----
> 
>   /branches/KDE/4.3/kdelibs/kio/kio/accessmanager.h 1036185 
>   /branches/KDE/4.3/kdelibs/kio/kio/accessmanager.cpp 1036185 
> 
> Diff: http://reviewboard.kde.org/r/1711/diff
> 
> 
> Testing
> -------
> 
> This code was already proven to work in the kdewebkit module.
> 
> 
> Thanks,
> 
> adawit
> 
>