Review Request: Fix QNetworkReply::downloadProgress signal in KIO::AccessManager

[Dawit A.]

Looks good to me... Dividing the result from totalAmount(KJob::Bytes) by 2046 
does not make sense at all. Perhaps it was working around a problem that no 
longer exists in kdewebkit where this class originated from ?

On Sunday 18 October 2009 11:37:21 Dario Freddi wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1879/
> -----------------------------------------------------------
> 
> Review request for kdelibs and Urs Wolfer.
> 
> 
> Summary
> -------
> 
> This patch fixes some mistakes when streaming downloadProgress from
>  QNetworkReply when using KIO::AccessManager. Before this patch, completely
>  random values were streamed out, and I honestly don't know for how long
>  this wrong behavior was lying around. I also made it stream the progress
>  in bytes, to be 100% compatible with QNetworkAccessManager. I also intend
>  to backport this patch, if approved.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/kio/kio/accessmanagerreply_p.cpp 1037205
> 
> Diff: http://reviewboard.kde.org/r/1879/diff
> 
> 
> Testing
> -------
> 
> The streamed values are now correct and coherent with
>  QNetworkAccessManager's one.
> 
> 
> Thanks,
> 
> Dario
>