Review Request: use member initialization lists in khtml

[Maksim Orlovich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1876/#review2694
-----------------------------------------------------------


Sorry, but very much NOT good. I appreciate you spending time on this, but it convolutes 
code history without any functional benefits.

- Maksim


On 2009-10-17 09:32:48, Jaime Torres wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1876/
> -----------------------------------------------------------
> 
> (Updated 2009-10-17 09:32:48)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Make use of the member initialization lists in the constructors of the header files.
> The red spaces are already removed.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/khtml/css/css_base.h 1036373 
>   /trunk/KDE/kdelibs/khtml/dom/QualifiedName.h 1036373 
>   /trunk/KDE/kdelibs/khtml/dom/css_stylesheet.h 1036373 
>   /trunk/KDE/kdelibs/khtml/dom/dom2_range.h 1036373 
>   /trunk/KDE/kdelibs/khtml/dom/dom_exception.h 1036373 
>   /trunk/KDE/kdelibs/khtml/ecma/kjs_proxy.h 1036373 
>   /trunk/KDE/kdelibs/khtml/html/htmltokenizer.h 1036373 
>   /trunk/KDE/kdelibs/khtml/khtmlpart_p.h 1036373 
>   /trunk/KDE/kdelibs/khtml/misc/AtomicString.h 1036373 
>   /trunk/KDE/kdelibs/khtml/misc/idstring.h 1036373 
>   /trunk/KDE/kdelibs/khtml/misc/loader.h 1036373 
>   /trunk/KDE/kdelibs/khtml/misc/paintbuffer.h 1036373 
>   /trunk/KDE/kdelibs/khtml/misc/shared.h 1036373 
>   /trunk/KDE/kdelibs/khtml/platform/graphics/IntRect.h 1036373 
>   /trunk/KDE/kdelibs/khtml/rendering/bidi.h 1036373 
>   /trunk/KDE/kdelibs/khtml/rendering/render_block.h 1036373 
>   /trunk/KDE/kdelibs/khtml/rendering/render_canvas.h 1036373 
>   /trunk/KDE/kdelibs/khtml/rendering/render_flow.h 1036373 
>   /trunk/KDE/kdelibs/khtml/rendering/render_line.h 1036373 
>   /trunk/KDE/kdelibs/khtml/rendering/render_position.h 1036373 
>   /trunk/KDE/kdelibs/khtml/rendering/render_replaced.h 1036373 
>   /trunk/KDE/kdelibs/khtml/rendering/render_style.h 1036373 
>   /trunk/KDE/kdelibs/khtml/svg/SVGGlyphElement.h 1036373 
>   /trunk/KDE/kdelibs/khtml/xml/ClassNames.h 1036373 
>   /trunk/KDE/kdelibs/khtml/xml/dom_nodeimpl.h 1036373 
>   /trunk/KDE/kdelibs/khtml/xml/dom_nodelistimpl.h 1036373 
>   /trunk/KDE/kdelibs/khtml/xml/dom_stringimpl.h 1036373 
> 
> Diff: http://reviewboard.kde.org/r/1876/diff
> 
> 
> Testing
> -------
> 
> Everything I've seen keeps working as before.
> The acid2 test gets 100% with testkhtml, but still 80% with konqueror in a 64bits environment.
> 
> 
> Thanks,
> 
> Jaime
> 
>