Review Request: xml_tokenizer.cpp:536: warning: comparison between signed and unsigned integer expressions

[Maksim Orlovich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1865/#review2691
-----------------------------------------------------------

Ship it!


OK...

- Maksim


On 2009-10-16 17:46:52, Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1865/
> -----------------------------------------------------------
> 
> (Updated 2009-10-16 17:46:52)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> The dashboard
>   http://dashboard.akonadi-project.org/CDash/index.php?project=kdelibs
> reports:
> khtml/xml/xml_tokenizer.cpp:536: warning: comparison between signed and unsigned integer expressions
> khtml/xml/xml_tokenizer.cpp:540: warning: comparison between signed and unsigned integer expressions
> 
> at
> void XMLTokenizer::finish()
> 
> the local variable in the "for loop" is not proper declared.
> I propose "int"
> see: xml_tokenizer-gm-14.diff
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/khtml/xml/xml_tokenizer.cpp 1033934 
> 
> Diff: http://reviewboard.kde.org/r/1865/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy
> 
>