Review Request: Allow autostart .desktop files to be merged

[Lubos Lunak]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1857/#review2665
-----------------------------------------------------------


This is non-compliant with the specification, see 'Autostart Directories' in http://standards.freedesktop.org/autostart-spec/autostart-spec-latest.html .


- Lubos


On 2009-10-15 18:12:02, Aaron Seigo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1857/
> -----------------------------------------------------------
> 
> (Updated 2009-10-15 18:12:02)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> KAutostart in libkdecore uses KDesktopFile to manage the autostart entries and relies on KConfig's merging system to do so. However, klauncher was passing absolute paths to KService (which passes that to KDesktopFile) which prevents such merging. This patch uses the file name only to allow KDesktopFile to merge the entries. This breakage was recently discovered with the new desktop vs netbook shell setting in system settings.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kinit/autostart.cpp 1032509 
>   /trunk/KDE/kdelibs/kinit/klauncher.cpp 1032509 
> 
> Diff: http://reviewboard.kde.org/r/1857/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aaron
> 
>