Review Request: Allow to hide text for specific icons on toolbars

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1847/
-----------------------------------------------------------

(Updated 2009-10-15 12:49:11.437259)


Review request for kdelibs and usability.


Changes
-------

- UI text changes, it now reads "Icon text:" and "Hide text when toolbar shows text alongside icons"
- trim icon text spaces at beginning and end
- added "priority" attribute to the .xsd and .dtd files


Summary
-------

This replaces the previous text input dialog with a custom dialog that has an additional check box to hide the icon text when mode is "Text Alongside Icons". Requires Qt 4.6 to test.


This addresses bug 175123.
    https://bugs.kde.org/show_bug.cgi?id=175123


Diffs (updated)
-----

  /trunk/KDE/kdelibs/kdeui/dialogs/kedittoolbar.cpp 1035587 
  /trunk/KDE/kdelibs/kdeui/dialogs/kedittoolbar_p.h 1035587 
  /trunk/KDE/kdelibs/kdeui/xmlgui/kpartgui.dtd 1035587 
  /trunk/KDE/kdelibs/kdeui/xmlgui/kxmlgui.xsd 1035587 

Diff: http://reviewboard.kde.org/r/1847/diff


Testing
-------

Compiles and works on current trunk.


Screenshots
-----------

"Change Text..." dialog from toolbar editor
  http://reviewboard.kde.org/r/1847/s/227/


Thanks,

Christoph