Review Request: Allow translations of Qt4 style names

[Pino Toscano]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1845/#review2651
-----------------------------------------------------------


Just one note for all the *.themerc files of your patch: you don't need to add the 'x-test' translations, scripty takes care of any translation in *.desktop (and similar) files.

- Pino


On 2009-10-14 21:12:49, Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1845/
> -----------------------------------------------------------
> 
> (Updated 2009-10-14 21:12:49)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Please check
> * if I didn't mess up the whole i18n stuff
> * if the texts are good for translation
> * if we are allowed to use names such as Apple, Windows, Vista, etc. in descriptions
> * if the bug is worth fixing at all :)
> 
> 
> This addresses bug 152947.
>     https://bugs.kde.org/show_bug.cgi?id=152947
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/runtime/kstyles/CMakeLists.txt 1035269 
>   /trunk/KDE/kdebase/runtime/kstyles/themes/CMakeLists.txt 1035269 
>   /trunk/KDE/kdebase/runtime/kstyles/themes/qtcleanlooks.themerc PRE-CREATION 
>   /trunk/KDE/kdebase/runtime/kstyles/themes/qtgtk.themerc PRE-CREATION 
>   /trunk/KDE/kdebase/runtime/kstyles/themes/qtmacintosh.themerc PRE-CREATION 
>   /trunk/KDE/kdebase/runtime/kstyles/themes/qtplastique.themerc PRE-CREATION 
>   /trunk/KDE/kdebase/runtime/kstyles/themes/qtwindowsvista.themerc PRE-CREATION 
>   /trunk/KDE/kdebase/runtime/kstyles/themes/qtwindowsxp.themerc PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/1845/diff
> 
> 
> Testing
> -------
> 
> Builds, installs, and shows the descriptions in my (english) system, instead of the old "No description available" in systemsettings.
> 
> 
> Thanks,
> 
> Christoph
> 
>