[KDE Usability] Review Request: Allow to hide text for specific icons on toolbars

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1847/#review2640
-----------------------------------------------------------


Looks good, except for two things:

* Surely a change in kxmlguifactory is missing so that the new xml attribute is read (to honor the setting after restarting the app), isn't it?

* The text of the label is a bit confusing. I had to read the Qt docs to understand that it would hide the text when the icon is shown,
and now when icon isn't shown. Hmm. Maybe "Hide text when icon is shown"? "Hide text (except in text only mode)"? Not satisfactory ;)
The point is that it seemed illogical to be able to enter a text, and then ask for it to be hidden.
Or do you disable the lineedit when the checkbox is checked (because the user knows if he wants TextOnly or IconText for the toolbar anyway)?


- David


On 2009-10-13 23:44:41, Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1847/
> -----------------------------------------------------------
> 
> (Updated 2009-10-13 23:44:41)
> 
> 
> Review request for kdelibs and usability.
> 
> 
> Summary
> -------
> 
> This replaces the previous text input dialog with a custom dialog that has an additional check box to hide the icon text when mode is "Text Alongside Icons". Requires Qt 4.6 to test.
> 
> 
> This addresses bug 175123.
>     https://bugs.kde.org/show_bug.cgi?id=175123
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdeui/dialogs/kedittoolbar.cpp 1034928 
>   /trunk/KDE/kdelibs/kdeui/dialogs/kedittoolbar_p.h 1034928 
> 
> Diff: http://reviewboard.kde.org/r/1847/diff
> 
> 
> Testing
> -------
> 
> Compiles and works on current trunk.
> 
> 
> Screenshots
> -----------
> 
> "Change Text..." dialog from toolbar editor
>   http://reviewboard.kde.org/r/1847/s/227/
> 
> 
> Thanks,
> 
> Christoph
> 
>