Review Request: Fix several issues on kdelibs/kdeui reported by Krazy2 checks

David Faure faure at kde.org
Tue Oct 13 10:20:39 BST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1838/#review2627
-----------------------------------------------------------

Ship it!


Trivial enough, looks fine to me.

- David


On 2009-10-13 00:33:41, Darío Andrés wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1838/
> -----------------------------------------------------------
> 
> (Updated 2009-10-13 00:33:41)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Fixed several QString issues reported by Krazy2. Posting here to not break kdelibs without permission
> 
> 
> Diffs
> -----
> 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kdeui/actions/kaction.cpp 1034418 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kdeui/actions/kactioncollection.cpp 1034418 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kdeui/dialogs/kconfigdialogmanager.cpp 1034418 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kdeui/dialogs/kshortcutseditor.cpp 1034418 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kdeui/icons/kiconloader.cpp 1034418 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kdeui/icons/kicontheme.cpp 1034418 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kdeui/itemviews/kdescendantsproxymodel.cpp 1034418 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kdeui/itemviews/kselectionproxymodel.h 1034418 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kdeui/itemviews/kselectionproxymodel.cpp 1034418 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kdeui/kernel/kglobalsettings.cpp 1034418 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kdeui/notifications/knotificationitem.cpp 1034418 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kdeui/shortcuts/kglobalaccel.cpp 1034418 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kdeui/shortcuts/kshortcut.cpp 1034418 
> 
> Diff: http://reviewboard.kde.org/r/1838/diff
> 
> 
> Testing
> -------
> 
> Code compiles. The small changes should not affect the code behavior
> 
> 
> Thanks,
> 
> Darío
> 
>





More information about the kde-core-devel mailing list