Review Request: value.cpp: 224: comparison between signed and unsigned integer

Guy Maurel guy-kde at maurel.de
Mon Oct 12 18:57:33 BST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1830/
-----------------------------------------------------------

(Updated 2009-10-12 17:57:33.322254)


Review request for kdelibs.


Changes
-------

use static_cast<unsigned>()


Summary
-------

The kdelibs-Dashboard reports:
/.../kdelibs/kjs/value.cpp:224: warning: comparison between signed and unsigned integer expressions

at
Value* JSValue::getByIndex(ExecState* exec, unsigned propertyName) const

my proposal is to make a little change, a cast


Diffs (updated)
-----

  /trunk/KDE/kdelibs/kjs/value.cpp 1033934 

Diff: http://reviewboard.kde.org/r/1830/diff


Testing
-------


Thanks,

Guy





More information about the kde-core-devel mailing list