Review Request: Update KTabBar and KTabWidget to use the Qt>=4.5 "setSelectionBehaviorOnRemove" functions (QTabBar)

Darío Andrés andresbajotierra at
Sun Oct 11 17:18:27 BST 2009

This is an automatically generated e-mail. To reply, visit:

(Updated 2009-10-11 16:18:27.506326)

Review request for kdelibs.


Updated diff. Do not remove the non-virtual unused slot (BC). Added a comment about it.
Thanks to Stefan Majewsky


This patches removes the duplicated function of "KTabWidget" about selecting the previous tab on deletion (this feature was also conflicting with QTabWidget/QTabBar if the "selectionBehaviorOnRemove" was set to "SelectPreviousTab")
It also forces "KTabBar" to use "(set)selectionBehaviorOnRemove"(from Qt) on its function "setTabCloseActivatePrevious"
Qt docs says that the default value is "SelectRightTab"; however I don't know if RTL users agree with this....
I also removed a non virtual slot from KTabWidget as it was not used anymore (this should be compatible.. am I wrong?)

- Should the APIDOX be modified/updated ?

This addresses bugs 181124 and 207747.

Diffs (updated)

  svn:// 1033579 
  svn:// 1033579 



I tested this in Konqueror and it worked properly explains more testcase situations (investigation before the patch)



More information about the kde-core-devel mailing list