Review Request: Update KTabBar and KTabWidget to use the Qt>=4.5 "setSelectionBehaviorOnRemove" functions (QTabBar)

[Stefan Majewsky]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1823/#review2605
-----------------------------------------------------------


Removing a non-virtual slot is not binary compatible, because the slot can also be called like a normal method (in fact, it is a normal method). Removing this method would remove a symbol, which can possibly not be dynamically bound anymore.

- Stefan


On 2009-10-11 15:24:08, Darío Andrés wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1823/
> -----------------------------------------------------------
> 
> (Updated 2009-10-11 15:24:08)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This patches removes the duplicated function of "KTabWidget" about selecting the previous tab on deletion (this feature was also conflicting with QTabWidget/QTabBar if the "selectionBehaviorOnRemove" was set to "SelectPreviousTab")
> It also forces "KTabBar" to use "(set)selectionBehaviorOnRemove"(from Qt) on its function "setTabCloseActivatePrevious"
> Qt docs says that the default value is "SelectRightTab"; however I don't know if RTL users agree with this....
> I also removed a non virtual slot from KTabWidget as it was not used anymore (this should be compatible.. am I wrong?)
> 
> - Should the APIDOX be modified/updated ?
> 
> 
> This addresses bugs 181124 and 207747.
>     https://bugs.kde.org/show_bug.cgi?id=181124
>     https://bugs.kde.org/show_bug.cgi?id=207747
> 
> 
> Diffs
> -----
> 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kdeui/widgets/ktabbar.cpp 1033579 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kdeui/widgets/ktabwidget.h 1033579 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kdeui/widgets/ktabwidget.cpp 1033579 
> 
> Diff: http://reviewboard.kde.org/r/1823/diff
> 
> 
> Testing
> -------
> 
> I tested this in Konqueror and it worked properly
> https://bugs.kde.org/show_bug.cgi?id=181124 explains more testcase situations (investigation before the patch)
> 
> 
> Thanks,
> 
> Darío
> 
>