Review Request: Add Odd/Even Page Set and Server Side Page Range to Qt Print Dialog via CUPS

[John Layt]

> On 2009-10-04 20:10:26, Albert Astals Cid wrote:
> > Seems a bit hacky but not that much compared to how much people complaint about this feature. This feature will be transparent for app developers that use QPrinter, right? I mean i just print everything but cups just prints odd pages? Will we need to add support to okular fileprinter for that, right?

Yep, odd/even is completely transparent to the app, they just print the page range selected by the user as they currently do and CUPS does the rest, same as the other CUPS features like n-up.  It already works in Okular without any changes to FilePrinter required.  The hacky part of it is not strictly necessary, the combo could be on the Pages tab that we create, but that's not where the users expect it.


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1785/#review2543
-----------------------------------------------------------


On 2009-10-04 18:14:19, John Layt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1785/
> -----------------------------------------------------------
> 
> (Updated 2009-10-04 18:14:19)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> With the printing enhancements not making it into Qt 4.6, we need an interim fix to provide Odd/Even page selection and support of server side page range selection.  This is possible by extending the current CUPS support to provide these features under CUPS only.
> 
> 1) Odd/Even pages.  This is achieved through a hack to add extra widgets to the actual Qt dialog Copies tab by using findWidget() and insertWidget().  This is the only controversial part and the bit I want review on that it is acceptable in kdelibs and I've done it right.  See KCupsOptionsSettingsWidget::initPageSet() for the code that does this.  If not acceptable this can be moved to the Pages tab, but this is a less user friendly solution.
> 
> 2) Server side page range selection.  Some apps like Kate and Konqi can't/don't do page selection and force the user to print the entire document.  Cups does support selecting the pages for the app and this change allows the app to set a flag to tell it to do so.
> 
> Note also that I have now made all the KDE-added CUPS features only be added if the Qt version is < 4.7 as I'm fairly certain the new features will be available in Qt by then.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/kdeui/CMakeLists.txt 1030948 
>   trunk/KDE/kdelibs/kdeui/dialogs/kcupsoptionssettingswidget_p.h PRE-CREATION 
>   trunk/KDE/kdelibs/kdeui/dialogs/kcupsoptionssettingswidget_p.cpp PRE-CREATION 
>   trunk/KDE/kdelibs/kdeui/dialogs/kdeprintdialog.h 1030948 
>   trunk/KDE/kdelibs/kdeui/dialogs/kdeprintdialog.cpp 1030948 
> 
> Diff: http://reviewboard.kde.org/r/1785/diff
> 
> 
> Testing
> -------
> 
> My ink cartridge is getting very low :-)
> 
> 
> Screenshots
> -----------
> 
> Hack Page Set combo into QPrintDialog
>   http://reviewboard.kde.org/r/1785/s/218/
> 
> 
> Thanks,
> 
> John
> 
>