Review Request: fixes a crash I was having web-saving the acid3 test site.

[Maksim Orlovich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1763/#review2536
-----------------------------------------------------------


Wouldn't you still get the assert in RecuseData constructor before the first if?

Hmm, it may be a good idea to change the code to use ->document and not ->htmlDocument, and to change Archiver::RecurseData::document to DOM::Document instead of DOM::HTMLDocument, but the code likely
needs quite a few adjustments to handle XML properly anyway...

- Maksim


On 2009-10-03 10:25:46, Jaime Torres wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1763/
> -----------------------------------------------------------
> 
> (Updated 2009-10-03 10:25:46)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Fixes a crash I was having web-saving the acid3 test site. (once passed the test).
> Instead of triggering the ASSERT, place a condition to do nothing (as there is nothing to do with an empty document).
> 
> I hope this is the right group. I have not found any group for extragear nor konqueror.
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/base/konq-plugins/webarchiver/archivedialog.cpp 1030845 
> 
> Diff: http://reviewboard.kde.org/r/1763/diff
> 
> 
> Testing
> -------
> 
> The acid3 test site now is archived. When tested the archived page it gives a very low score, but that is another story.
> 
> 
> Thanks,
> 
> Jaime
> 
>