Review Request: fixes a crash I was having web-saving the acid3 test site.

[Jaime Torres]

> On 2009-10-03 18:04:51, Maksim Orlovich wrote:
> > Wouldn't you still get the assert in RecuseData constructor before the first if?
> > 
> > Hmm, it may be a good idea to change the code to use ->document and not ->htmlDocument, and to change Archiver::RecurseData::document to DOM::Document instead of DOM::HTMLDocument, but the code likely
> > needs quite a few adjustments to handle XML properly anyway...

Yes, the if block got displaced preparing the patch.

I've tried with ->document, but it still crashes. There are documents not null with htmlDocument null.

I'm still not able to prepare the code to save XMLs.


- Jaime


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1763/#review2536
-----------------------------------------------------------


On 2009-10-03 18:46:29, Jaime Torres wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1763/
> -----------------------------------------------------------
> 
> (Updated 2009-10-03 18:46:29)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Fixes a crash I was having web-saving the acid3 test site. (once passed the test).
> Instead of triggering the ASSERT, place a condition to do nothing (as there is nothing to do with an empty document).
> 
> I hope this is the right group. I have not found any group for extragear nor konqueror.
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/base/konq-plugins/webarchiver/archivedialog.cpp 1030845 
> 
> Diff: http://reviewboard.kde.org/r/1763/diff
> 
> 
> Testing
> -------
> 
> The acid3 test site now is archived. When tested the archived page it gives a very low score, but that is another story.
> 
> 
> Thanks,
> 
> Jaime
> 
>