Review Request: Rename all files or folders and create "apply to all" checkbox in KIO rename dialog

Sat Nov 28 21:20:41 GMT 2009

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2281/#review3323
-----------------------------------------------------------

/trunk/KDE/kdelibs/kio/kio/copyjob.cpp
<http://reviewboard.kde.org/r/2281/#comment2616>

    There is a trailing ";" after the brace.

/trunk/KDE/kdelibs/kio/kio/renamedialog.h
<http://reviewboard.kde.org/r/2281/#comment2618>

    This is a binary incompatible change. You can only add enum values, not change them.

    RenameDialog is a public exported class.

/trunk/KDE/kdelibs/kio/kio/renamedialog.h
<http://reviewboard.kde.org/r/2281/#comment2619>

    Missing @since tag for new public function, if this needs to be public at all?

/trunk/KDE/kdelibs/kio/kio/renamedialog.cpp
<http://reviewboard.kde.org/r/2281/#comment2615>

    This checkbox does not have any tooltip.

    You removed the "(Action) All" buttons, and the tooltips with them, which contain valuable information to the user.

/trunk/KDE/kdelibs/kio/kio/renamedialog.cpp
<http://reviewboard.kde.org/r/2281/#comment2620>

    Indentation is four spaces in kdelibs. Since this is a new function, there is no need to look at other functions to copy a coding style from.

    I won't add separate comments for the other coding style related issues, there are still braces placed below the "if" or "for" line, inconsistencies in spacing around parenthesis, and trailing white space (you can spot them using this reviewboard's diff viewer).

Further comments:

As discussed on #kde-devel, I am not really sure that adding a checkbox next to the buttons is a good thing to do, think about conversion to QDialogButtonBox later. I understand your rationale, but it looks unusual. I would like to get feedback from others here, so maybe add "usability" and "Dolphin" to review groups. Moving the checkbox to a different place would introduce a string change (also see below), but I could accept the current position as an interim solution for 4.4.

I have not tested the patch yet. I hope you have considered remote URLs, too.

It's a bit unfortunate that you request review on the message freeze day; you need to coordinate with the translation team (kde-i18n-doc list) if this can get approved for 4.4. Remember that your change does not only add a message string, but also changes the way the dialog works, so probably parts of the documentation text has be reworded accordingly.

Having the patch available or discussed a few weeks earlier would be a good thing for the future.

- Christoph

On 2009-11-28 18:42:26, Todd wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2281/
> -----------------------------------------------------------
> 
> (Updated 2009-11-28 18:42:26)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This patch makes two changes to the KIO file rename dialog box (the dialog box that appears when there is a file or folder name conflict when moving or copying files).  First, it adds the ability to automatically rename the files using the default file renaming rules (what you would get if you clicked "Suggest Name" once).  This is useful to avoid data loss, since you will not overwrite duplicate files or folders.
> 
> Second, because there are already a lot of possible buttons in the dialog box (rename, suggest name, overwrite, overwrite all, skip, auto skip, resume, resume all, and cancel), and since this patch would add another button, this patch eliminates "overwrite all", "auto skip", and "resume all" buttons and adds a single "apply to all" check box.  This check box changes each single-file button action to its corresponding multi-file action.  So when checked, "overwrite" behaves as "overwrite all", "skip" behaves as "auto skip", etc.  So despite the increased functionality this leads to a net reduction of up to 2 buttons, depending on the circumstances.
> 
> I know this is very late, but I think it is an important feature since there are several bug reports requesting this.  This is my first submission to KDE, so I apologize beforehand if the patch is not perfect.  I tried to follow KDE style guidelines, but there may be some commonly accepted conventions I am not aware of. 
> 
> Edit: Per a suggestion I am adding the bug reports this idea addresses:
> 
> There are three bug reports I have been able to find in a fairly quick search requesting this feature.  The first one is actually mine, the other two are from other people.  Two at least have multiple votes, so I am not the only one to have noticed this problem.  :
> 
> https://bugs.kde.org/show_bug.cgi?id=177121
> https://bugs.kde.org/show_bug.cgi?id=100769
> https://bugs.kde.org/show_bug.cgi?id=165398
> 
> Further, I have seen numerous requests for improvements to this dialog box, but unfortunately without any specifics about what to improve.  So although I can't say for certain this is what those people wanted, there are many people dissatisfied with the dialog box overall.
> 
> There was also a discussion on the mailing list where the conclusion seemed to be that this is a good idea (see "Automatic rename in KIO rename dialog")
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kio/kio/copyjob.cpp 1053922 
>   /trunk/KDE/kdelibs/kio/kio/jobuidelegate.cpp 1053922 
>   /trunk/KDE/kdelibs/kio/kio/renamedialog.h 1053922 
>   /trunk/KDE/kdelibs/kio/kio/renamedialog.cpp 1053922 
> 
> Diff: http://reviewboard.kde.org/r/2281/diff
> 
> 
> Testing
> -------
> 
> I have used this dialog box under various combinations of file and/or folder conflicts with all of the buttons.  It appears to work fine.
> 
> 
> Screenshots
> -----------
> 
> Apply to all not pressed
>   http://reviewboard.kde.org/r/2281/s/270/
> Apply to all pressed
>   http://reviewboard.kde.org/r/2281/s/271/
> 
> 
> Thanks,
> 
> Todd
> 
>