Review Request: Add versioning check for thumbnailers.

[David Faure]

> On 2009-11-27 00:27:47, Christoph Feck wrote:
> > Looks better :) Btw, does it already handle old thumbnails from 4.3? If this fixes updating those thumbnails to get correct rotation, it should be applied for 4.4. This is actually a smart solution, as we have no other way yet to force an update of the thumbnails. And I agree with you on the == issues. Whenever a thumbnail is detected from an old thumbnailer, it should be updated.
> > 
> > But the version should then only be updated if the generated thumbnail actually may be different, not just if the author thinks he made a cool new release. That needs to be documented somehow (and somewhere).
> 
> Peter Penz wrote:
>     > But the version should then only be updated if the generated
>     > thumbnail actually may be different, not just if the author
>     > thinks he made a cool new release. That needs to be documented
>     > somehow (and somewhere).
>     
>     +1
>     
>     This still makes me think why there is a need for a version number like x.y.z. Assuming that we have just an increasing number like in in the KPart-GUI (e. g. <kpartgui name="dolphin" version="12">): I don't see the benefit of making a x.y.z version just to create quite complicated code to do a version check of the first number... So my proposal would be just using a simple version number instead, that must be increased if the thumbnails should be regenerated.
>     
>     But in any case this patch should be part of KDE 4.4 as it fixes the "wrong rotation of JPEGs" issue.
> 
> Jacopo De Simoi wrote:
>     @Christoph
>     > Btw, does it already handle old thumbnails from 4.3? 
>     Yes, if the thumbnailer provides a version number AND the cached thumbnail doesn't have one, then the cached version is assumed to be obsolete.
>     
>     @Peter
>     >So my proposal would be just using a simple version number instead, that must be increased if the thumbnails should be regenerated.
>     Indeed, that could be a nice idea. After all, all versioning is internal. I'll remove checks for .y.z, then
>     
>     >But in any case this patch should be part of KDE 4.4 as it fixes the "wrong rotation of JPEGs" issue.
>     I agree, this patch in fact originated as a way to solve that specific issue.
> 
> David Faure wrote:
>     I completely agree. Integer version numbers are much simpler to handle, x.y.z is not needed here. I think it would even be confusing (people would always update them to match the KDE version number, and thumbnails would keep getting recreated).

I completely agree. Integer version numbers are much simpler to handle, x.y.z is not needed here. I think it would even be confusing (people would always update them to match the KDE version number, and thumbnails would keep getting recreated).


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2282/#review3312
-----------------------------------------------------------


On 2009-11-26 22:08:59, Jacopo De Simoi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2282/
> -----------------------------------------------------------
> 
> (Updated 2009-11-26 22:08:59)
> 
> 
> Review request for kdelibs, Peter Penz, David Nolden, and David Faure.
> 
> 
> Summary
> -------
> 
> Adds versioning check for thumbnailers; the code checks if a ThumbnailerVersion is defined and if so, checks that the software field in the existing thumbnail matches before using the cached thumbnail. 
> 
> This fixes caching bugs with the improved jpeg thumbnailer.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/kio/kio/previewjob.cpp 1038240 
> 
> Diff: http://reviewboard.kde.org/r/2282/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jacopo
> 
>