Review Request: Add versioning check for thumbnailers.

[Peter Penz]

> On 2009-11-27 00:27:47, Christoph Feck wrote:
> > Looks better :) Btw, does it already handle old thumbnails from 4.3? If this fixes updating those thumbnails to get correct rotation, it should be applied for 4.4. This is actually a smart solution, as we have no other way yet to force an update of the thumbnails. And I agree with you on the == issues. Whenever a thumbnail is detected from an old thumbnailer, it should be updated.
> > 
> > But the version should then only be updated if the generated thumbnail actually may be different, not just if the author thinks he made a cool new release. That needs to be documented somehow (and somewhere).

> But the version should then only be updated if the generated
> thumbnail actually may be different, not just if the author
> thinks he made a cool new release. That needs to be documented
> somehow (and somewhere).

+1

This still makes me think why there is a need for a version number like x.y.z. Assuming that we have just an increasing number like in in the KPart-GUI (e. g. <kpartgui name="dolphin" version="12">): I don't see the benefit of making a x.y.z version just to create quite complicated code to do a version check of the first number... So my proposal would be just using a simple version number instead, that must be increased if the thumbnails should be regenerated.

But in any case this patch should be part of KDE 4.4 as it fixes the "wrong rotation of JPEGs" issue.


- Peter


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2282/#review3312
-----------------------------------------------------------


On 2009-11-26 22:08:59, Jacopo De Simoi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2282/
> -----------------------------------------------------------
> 
> (Updated 2009-11-26 22:08:59)
> 
> 
> Review request for kdelibs, Peter Penz, David Nolden, and David Faure.
> 
> 
> Summary
> -------
> 
> Adds versioning check for thumbnailers; the code checks if a ThumbnailerVersion is defined and if so, checks that the software field in the existing thumbnail matches before using the cached thumbnail. 
> 
> This fixes caching bugs with the improved jpeg thumbnailer.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/kio/kio/previewjob.cpp 1038240 
> 
> Diff: http://reviewboard.kde.org/r/2282/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jacopo
> 
>