Review Request: Use the calculated QImage conversions
Christoph Feck
christoph at maxiom.de
Thu Nov 26 02:14:53 GMT 2009
> On 2009-11-25 23:54:22, Michael Pyne wrote:
> > Yes, this should be committed as convertToFormat is const so obviously we need to save the return value.
Commited as r1054453 and 54.
- Christoph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2279/#review3288
-----------------------------------------------------------
On 2009-11-25 00:22:22, Christoph Bartoschek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2279/
> -----------------------------------------------------------
>
> (Updated 2009-11-25 00:22:22)
>
>
> Review request for kdelibs.
>
>
> Summary
> -------
>
> In kiconeffect.cpp the images are converted to appropriate formats but the result is discarded. The patch uses the result as obviously intended.
>
>
> Diffs
> -----
>
> trunk/KDE/kdelibs/kdeui/icons/kiconeffect.cpp 1053878
>
> Diff: http://reviewboard.kde.org/r/2279/diff
>
>
> Testing
> -------
>
> No.
>
>
> Thanks,
>
> Christoph
>
>
More information about the kde-core-devel
mailing list