Review Request: Add versioning check for thumbnailers.
Christoph Feck
christoph at maxiom.de
Wed Nov 25 19:35:37 GMT 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2282/#review3277
-----------------------------------------------------------
trunk/KDE/kdelibs/kio/kio/previewjob.cpp
<http://reviewboard.kde.org/r/2282/#comment2586>
Versions are no floating point numbers, e.g. version 1.30 is "better" than 1.5.
- Christoph
On 2009-11-25 19:17:00, Jacopo De Simoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2282/
> -----------------------------------------------------------
>
> (Updated 2009-11-25 19:17:00)
>
>
> Review request for kdelibs, Peter Penz, David Nolden, and David Faure.
>
>
> Summary
> -------
>
> Adds versioning check for thumbnailers; the code checks if a ThumbnailerVersion is defined and if so, checks that the software field in the existing thumbnail matches before using the cached thumbnail.
>
> This fixes caching bugs with the improved jpeg thumbnailer.
>
>
> Diffs
> -----
>
> trunk/KDE/kdelibs/kio/kio/previewjob.cpp 1038240
>
> Diff: http://reviewboard.kde.org/r/2282/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jacopo
>
>
More information about the kde-core-devel
mailing list