Review Request: Rename all files or folders and create "apply to all" checkbox in KIO rename dialog

[Parker Coates]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2281/#review3264
-----------------------------------------------------------


Since this feature isn't included in the 4.4 feature plan, it is simply too late for inclusion in KDE SC 4.4.

But for 4.5, this seems like a good idea. I'm not familiar with the KIO code, but I did notice a few general things.


/trunk/KDE/kdelibs/kio/kio/copyjob.cpp
<http://reviewboard.kde.org/r/2281/#comment2575>

    The usage of curly braces is inconsistent. Looking around, it seems that there were inconsistencies even before your patch. Generally in such cases all new code should follow the kdelibs coding style.



/trunk/KDE/kdelibs/kio/kio/renamedialog.cpp
<http://reviewboard.kde.org/r/2281/#comment2576>

    If the "* All" buttons don't exist anymore, their pointers should be removed.



/trunk/KDE/kdelibs/kio/kio/renamedialog.cpp
<http://reviewboard.kde.org/r/2281/#comment2577>

    These *AllPressed() slots aren't used anymore either, are they? If that's the case, they should be removed.


Some screenshots would also be nice if you want feedback on the UI.



- Parker


On 2009-11-25 14:20:36, Todd wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2281/
> -----------------------------------------------------------
> 
> (Updated 2009-11-25 14:20:36)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This patch makes two changes to the KIO file rename dialog box (the dialog box that appears when there is a file or folder name conflict when moving or copying files).  First, it adds the ability to automatically rename the files using the default file renaming rules (what you would get if you clicked "Suggest Name" once).  This is useful to avoid data loss, since you will not overwrite duplicate files or folders.
> 
> Second, because there are already a lot of possible buttons in the dialog box (rename, suggest name, overwrite, overwrite all, skip, auto skip, resume, resume all, and cancel), and since this patch would add another button, this patch eliminates "overwrite all", "auto skip", and "resume all" buttons and adds a single "apply to all" check box.  This check box changes each single-file button action to its corresponding multi-file action.  So when checked, "overwrite" behaves as "overwrite all", "skip" behaves as "auto skip", etc.  So despite the increased functionality this leads to a net reduction of up to 2 buttons, depending on the circumstances.
> 
> I know this is very late, but I think it is an important feature since there are several bug reports requesting this.  This is my first submission to KDE, so I apologize beforehand if the patch is not perfect.  I tried to follow KDE style guidelines, but there may be some commonly accepted conventions I am not aware of. 
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kio/kio/jobuidelegate.cpp 1053922 
>   /trunk/KDE/kdelibs/kio/kio/renamedialog.h 1053922 
>   /trunk/KDE/kdelibs/kio/kio/renamedialog.cpp 1053922 
>   /trunk/KDE/kdelibs/kio/kio/copyjob.cpp 1053922 
> 
> Diff: http://reviewboard.kde.org/r/2281/diff
> 
> 
> Testing
> -------
> 
> I have used this dialog box under various combinations of file and/or folder conflicts with all of the buttons.  It appears to work fine.
> 
> 
> Thanks,
> 
> Todd
> 
>