Freeze exemption for PA integration into Phonon

[Raphael Kubo da Costa]

On Friday 20 November 2009 07:06:08 Colin Guthrie wrote:
> 'Twas brillig, and Christoph Feck at 20/11/09 01:55 did gyre and gimble:
> > Building kdebase r1051746 with kdesupport r1051730 I get the following
> > error in kdebase:
> >
> > /local/svn/kde/trunk/KDE/kdebase/runtime/phonon/kcm/devicepreference.cpp:
> > In member function 'void DevicePreference::load()':
> > /local/svn/kde/trunk/KDE/kdebase/runtime/phonon/kcm/devicepreference.cpp:
> >330: error: 'class Phonon::GlobalConfig' has no member named
> > 'getHideAdvancedDevices'
> > /local/svn/kde/trunk/KDE/kdebase/runtime/phonon/kcm/devicepreference.cpp:
> > In member function 'void DevicePreference::on_showCheckBox_toggled()':
> > /local/svn/kde/trunk/KDE/kdebase/runtime/phonon/kcm/devicepreference.cpp:
> >548: error: no matching function for call to
> > 'Phonon::GlobalConfig::hideAdvancedDevices(bool)'
> > /local/kde4/include/phonon/globalconfig.h:51: note: candidates are: bool
> > Phonon::GlobalConfig::hideAdvancedDevices() const
> > make[2]: ***
> > [runtime/phonon/kcm/CMakeFiles/kcm_phonon.dir/devicepreference.o] Error 1
> > make[2]: Target `runtime/phonon/kcm/CMakeFiles/kcm_phonon.dir/build' not
> > remade because of errors.
> > make[1]: *** [runtime/phonon/kcm/CMakeFiles/kcm_phonon.dir/all] Error 2
> 
> Gah, Sorry about that. This was a cleanup change from Matthias that
> looked harmless when I reviewed it (I thought these were left over APIs
> I'd defined during a failed part of the process but forgotten to remove).
> 
> Phonon trunk should have them exported again.
> 
> Thanks also to mpyne who tweaked the cmake file. I originally copied
> this from one of the other KDE packages but due to git-svn it didn't
> mark it as an svn cp... I should make sure that these files are kept in
> sync or that the FindPulseAudio.cmake is moved to somewhere central...
> any suggestions?
> 
> Col

When building kdebase today, I got the following error:

/home/kubo/kde4/src/kdebase/runtime/phonon/kcm/devicepreference.cpp: In member 
function ‘void DevicePreference::load()’:
/home/kubo/kde4/src/kdebase/runtime/phonon/kcm/devicepreference.cpp:330: 
error: ‘GlobalConfig’ is not a member of ‘Phonon’
/home/kubo/kde4/src/kdebase/runtime/phonon/kcm/devicepreference.cpp: In member 
function ‘void DevicePreference::loadCategoryDevices()’:
/home/kubo/kde4/src/kdebase/runtime/phonon/kcm/devicepreference.cpp:339: 
error: ‘GlobalConfig’ is not a member of ‘Phonon’
/home/kubo/kde4/src/kdebase/runtime/phonon/kcm/devicepreference.cpp:348: 
error: ‘GlobalConfig’ is not a member of ‘Phonon’
/home/kubo/kde4/src/kdebase/runtime/phonon/kcm/devicepreference.cpp: In member 
function ‘void DevicePreference::save()’:
/home/kubo/kde4/src/kdebase/runtime/phonon/kcm/devicepreference.cpp:371: 
error: ‘GlobalConfig’ is not a member of ‘Phonon’
/home/kubo/kde4/src/kdebase/runtime/phonon/kcm/devicepreference.cpp:377: 
error: ‘GlobalConfig’ is not a member of ‘Phonon’
/home/kubo/kde4/src/kdebase/runtime/phonon/kcm/devicepreference.cpp: In member 
function ‘void DevicePreference::on_showCheckBox_toggled()’:
/home/kubo/kde4/src/kdebase/runtime/phonon/kcm/devicepreference.cpp:548: 
error: ‘GlobalConfig’ is not a member of ‘Phonon’

Does it mean Phonon from kdesupport is now mandatory in order to build 
kdebase?