Review Request: Reduce the warnings about unused parameters

Darío Andrés andresbajotierra at gmail.com
Sat Nov 21 01:49:37 GMT 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2252/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

I added a bunch of Q_UNUSED macros and removed other params (only where its value was obvious)
Some of the parameters should be review... (parent QObjects not being used?)


Diffs
-----

  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/interfaces/kimproxy/library/kimproxy.cpp 1051972 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/interfaces/ktexteditor/codecompletionmodelcontrollerinterface.cpp 1051972 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/interfaces/ktexteditor/ktexteditor.cpp 1051972 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kate/completion/expandingtree/expandingdelegate.cpp 1051972 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kate/plugins/exporter/exporterpluginview.cpp 1051972 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kate/plugins/pythonencoding/python_encoding.h 1051972 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kate/smart/katesmartmanager.cpp 1051972 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kate/tests/annotationmodeltest.cpp 1051972 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kate/tests/arbitraryhighlighttest.cpp 1051972 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kate/utils/katetemplatehandler.cpp 1051972 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kdecore/auth/backends/dbus/DBusHelperProxy.cpp 1051972 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kdecore/network/kssld/kssld.cpp 1051972 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kdecore/network/ktcpsocket.cpp 1051972 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kdecore/sycoca/ksycocafactory.h 1051972 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kdecore/tests/ksortablelisttest.cpp 1051972 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kdeui/itemviews/kcategorydrawer.cpp 1051972 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kdeui/itemviews/kdescendantsproxymodel.cpp 1051972 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kdeui/itemviews/kselectionproxymodel.cpp 1051972 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kdeui/tests/kmodifierkeyinfotest.cpp 1051972 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kdeui/windowmanagement/kwindowsystem_x11.cpp 1051972 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kdeui/xmlgui/ktoolbarhandler.cpp 1051972 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kio/kfile/kfilemetainfowidget.cpp 1051972 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kio/kfile/kimagefilepreview.cpp 1051972 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kio/kio/kurlcompletion.cpp 1051972 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kparts/browserrun.cpp 1051972 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kparts/part.cpp 1051972 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kross/ui/model.cpp 1051972 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/animations/rotationstacked.cpp 1051972 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/private/qtjolie-branch/qtjolie/abstractadaptor.cpp 1051972 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/widgets/scrollwidget.cpp 1051972 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/widgets/spinbox.cpp 1051972 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/solid/solid/backends/fakehw/fakecamera.cpp 1051972 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/solid/solid/backends/fakehw/fakeportablemediaplayer.cpp 1051972 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/solid/solid/powermanagement.cpp 1051972 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/solid/tests/halbasictest.cpp 1051972 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/threadweaver/Weaver/DependencyPolicy.cpp 1051972 

Diff: http://reviewboard.kde.org/r/2252/diff


Testing
-------

It compiles


Thanks,

Darío





More information about the kde-core-devel mailing list