KMenu title is navigable with the keyboard

Hugo Pereira Da Costa hugo at oxygen-icons.org
Thu Nov 19 17:29:57 GMT 2009


Hello Albert

If not already done, you should commit the patch, so that current title 
widgets are rendered properly.

I should fix the style (this is done locally, I just have to commit), so 
that both the "hacked separator" and the current widget are rendered the 
same way.

I would rather not let the style hack the collapse separator style. This 
is an application issue.

At some point, (after kde4.4 is out) one could possibly replace the 
title widget (internals) to use these hacked separators, or leave the 
situation like now (after patch). Not a big deal.

Hacked separators allow Qt+Non kde applications to put titles/headers in 
the menu, (for styles that supports it), but this is again left to the 
application.

This to say: is it ok to commit my changes to oxygen-style ? I don't 
think it conflicts with your patch in any way.

Hugo

>> Am Wednesday 18 November 2009 schrieb Albert Astals Cid:
>>      
>>> It's already a widget, the problem is that if you make it a widget then
>>> you need my patch so that keyboard navigation works.
>>>        
>> I rather meant "Plain QWidget instead a Toolbutton", but regarding the
>> keyboard -
>> a) QMenu jumps disabled items (though this is style dependent for actions
>>   and i'm not sure about widgets)
>> b) have you tested whether setting the proper focuspolicy (NoFocus) does
>>   it?
>>      
> Depending on the style is not possible, since we want that the title items
> don't get the focus for all the styles, and yes, i've tested NoFocus and
> doesn't help.
>
> Any more suggestion or do i go with my patch?
>
> Albert
>
>    
>>
>> Cheers
>>
>>      
>    





More information about the kde-core-devel mailing list