Moving LibAttica to kdesupport

[Frederik Gladhorn]

Hi Alex,
I'm sorry, I wasn't aware of the CMake policy. In hindsight it makes a lot 
of sense.
Please excuse my ignorance.

Alexander Neundorf wrote:
> Hi Frederik,
<snip>
> I just noticed that you added a cmake module FindAttica.cmake to
> kdelibs/cmake/modules/, which is also installed.
> 
> When working with the cmake modules in kdelibs, the commit policy should
> be followed: http://techbase.kde.org/Policies/CMake_Commit_Policy
> (first rule there says "new files must be sent to kde-buildsystem at kde.org
> for review. They may only be added after an explicit Ok.")
> 
> You did not do that and from you emails about moving it to kdereview it
> also was not obvious that it involves the cmake modules for kdelibs.
> 
> Why is that important...
> Adding a module to kdelibs which is also installed means you add a part of
> the public API which must be kept compatible for all of KDE 4.
> So installing such a file comes with a cost.
> 
> I had a look at the file as it is now, and it is not good.
> 
> It does not work at all on Windows, it used pkg-config in a bad and
> documented as such) way. It cannot stay as it is now.
> Please have a look e.g. at FindLibXml2.cmake for a proper example how to
> use pkg-config in a cmake module.

Please see the attached FindAttica.cmake if it is in better shape. As total 
cmake noob, I'm not sure if it's ok now.

> Next question: is this module actually necessary at all ?
> Who are the users of it ?
You are right, that so far no applications use attica, but I have a branch 
where KHotNewStuff uses it to implement many features that have been 
requested ages ago. I'd like to merge that to kdelibs in the very near 
future. Two plasma applets and Amarok have local copies of this library at 
the moment and are waiting for a real library.

Greetings
Frederik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: FindAttica.cmake
Type: text/x-cmake
Size: 1453 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20091117/c7fe251f/attachment.bin>