Review Request: Quit Eventloop before emitting finished and result signals

[Sebastian Sauer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2140/
-----------------------------------------------------------

(Updated 2009-11-11 22:05:36.556832)


Review request for kdelibs.


Changes
-------

As suggested by Kevin removed the duplicated;

#ifndef Q_MOC_RUN
private: // be sure noone else calls the _internal_finished signal
#endif


Summary
-------

If KJob::exec is called then it can happen that the result(KJob*) signal is emitted before the QEventLoop in KJob::exec is quit. If a slot connected with the result(KJob*) signal does then e.g. call the same KJob::exec again then funny things may happen. The patch introduces a new internal signal that is called before the finished and result signals are emitted and that quits the eventloop. This way we can be sure that the finished and result signals are always emitted once the eventloop is done.


Diffs (updated)
-----

  /trunk/KDE/kdelibs/kdecore/jobs/kjob.h 1047234 
  /trunk/KDE/kdelibs/kdecore/jobs/kjob.cpp 1047234 

Diff: http://reviewboard.kde.org/r/2140/diff


Testing
-------


Thanks,

Sebastian