Review Request: Quit Eventloop before emitting finished and result signals

[Sebastian Sauer]

> On 2009-11-11 20:35:03, Kevin Krammer wrote:
> > /trunk/KDE/kdelibs/kdecore/jobs/kjob.h, line 501
> > <http://reviewboard.kde.org/r/2140/diff/1/?file=14357#file14357line501>
> >
> >     isn't this already ensured by the similar construct around line 419?

well, there is the additional...
#ifndef DOXYGEN_SHOULD_SKIP_THIS

Also if we look for duplicates then  line 419 is already one of line 324 :)


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2140/#review3038
-----------------------------------------------------------


On 2009-11-11 18:38:41, Sebastian Sauer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2140/
> -----------------------------------------------------------
> 
> (Updated 2009-11-11 18:38:41)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> If KJob::exec is called then it can happen that the result(KJob*) signal is emitted before the QEventLoop in KJob::exec is quit. If a slot connected with the result(KJob*) signal does then e.g. call the same KJob::exec again then funny things may happen. The patch introduces a new internal signal that is called before the finished and result signals are emitted and that quits the eventloop. This way we can be sure that the finished and result signals are always emitted once the eventloop is done.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdecore/jobs/kjob.h 1047234 
>   /trunk/KDE/kdelibs/kdecore/jobs/kjob.cpp 1047234 
> 
> Diff: http://reviewboard.kde.org/r/2140/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sebastian
> 
>