Locking toolbars by default

Aaron J. Seigo aseigo at kde.org
Tue Nov 10 22:28:15 GMT 2009


On November 10, 2009, Frederik Gladhorn wrote:
> Hi,
> 
> just recently I discussed with some people about the default setting for
> locked toolbars. Most people I spoke to, don't rearrange their toolbars
> often (if at all).
> So would it not make sense to have all toolbars locked by default?

attached is a patch that implements this. key points of this patch:

* renames "Lock Toolbars" to "Lock Toolbar Positions"

* renames menu title from "Toolbar Menu" to "Toolbar Settings"

* renames menu entry "Toolbars" to "Toolbars Shown", clearer and more 
consistent with the single entry name of "Show Toolbar"

* doesn't hide icon size or text alignment options when locked (which is an 
unfortunate problem with locking toolbars currently)

* puts a divider line in the menu between "this toolbar" and "all toolbar" 
options; may need to be even more obvious with a title, but i didn't think the 
visual "weight" of another title justified the benefits

* puts the items that are hidden when Locked at the bottom of their respective 
sections, making the menu change as little as possible when locked

* main toolbar text default is text-aside

normally i'd put this on review-board, but i figured in this case it was more 
useful to keep in the context of the thread.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks
-------------- next part --------------
A non-text attachment was scrubbed...
Name: toolbar_locking.diff
Type: text/x-patch
Size: 10084 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20091110/b211f0fa/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20091110/b211f0fa/attachment.sig>


More information about the kde-core-devel mailing list