Review Request: Nepomuk desktop query API

Sebastian Trueg trueg at kde.org
Tue Nov 10 16:14:19 GMT 2009 


> On 2009-11-10 15:58:25, Tobias Koenig wrote:
> >

I will finalize the API docs next week.


> On 2009-11-10 15:58:25, Tobias Koenig wrote:
> > trunk/KDE/kdelibs/nepomuk/query/filequery.h, line 42
> > <http://reviewboard.kde.org/r/2061/diff/4/?file=14179#file14179line42>
> >
> >     Add d-pointer to be future proof additional copyctor and operator= for FileQuery can be added later on

No need. If we really need to store additional data fields with FileQuery in the future we can use the same approach as for Term: a private class hierarchy.


> On 2009-11-10 15:58:25, Tobias Koenig wrote:
> > trunk/KDE/kdelibs/nepomuk/query/queryparser.h, line 105
> > <http://reviewboard.kde.org/r/2061/diff/4/?file=14201#file14201line105>
> >
> >     Should definitely be const

done.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2061/#review3001
-----------------------------------------------------------


On 2009-11-09 10:47:26, Sebastian Trueg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2061/
> -----------------------------------------------------------
> 
> (Updated 2009-11-09 10:47:26)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> One thing has been missing ever since KDE 4.0: A good Nepomuk query API. We cannot expect app developers to all learn SPARQL.
> This API is the final version (Virtuoso-extensions-based) of the query API that has already been in kdebase/workspace/libs/nepomukquery and kdebase/runtime/nepomuk/libnepomukquery. The API is already used by the Nepomuk query service, the Nepomuk search kio slave, the Nepomuk Plasma runner, and the simple search client in playground.
> 
> It makes perfect sense to include this API in KDE 4.4.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/includes/CMakeLists.txt 1044143 
>   trunk/KDE/kdelibs/includes/Nepomuk/Query/AndTerm PRE-CREATION 
>   trunk/KDE/kdelibs/includes/Nepomuk/Query/ComparisonTerm PRE-CREATION 
>   trunk/KDE/kdelibs/includes/Nepomuk/Query/FileQuery PRE-CREATION 
>   trunk/KDE/kdelibs/includes/Nepomuk/Query/GroupTerm PRE-CREATION 
>   trunk/KDE/kdelibs/includes/Nepomuk/Query/LiteralTerm PRE-CREATION 
>   trunk/KDE/kdelibs/includes/Nepomuk/Query/NegationTerm PRE-CREATION 
>   trunk/KDE/kdelibs/includes/Nepomuk/Query/OrTerm PRE-CREATION 
>   trunk/KDE/kdelibs/includes/Nepomuk/Query/Query PRE-CREATION 
>   trunk/KDE/kdelibs/includes/Nepomuk/Query/QueryParser PRE-CREATION 
>   trunk/KDE/kdelibs/includes/Nepomuk/Query/QueryServiceClient PRE-CREATION 
>   trunk/KDE/kdelibs/includes/Nepomuk/Query/ResourceTerm PRE-CREATION 
>   trunk/KDE/kdelibs/includes/Nepomuk/Query/Result PRE-CREATION 
>   trunk/KDE/kdelibs/includes/Nepomuk/Query/SimpleTerm PRE-CREATION 
>   trunk/KDE/kdelibs/includes/Nepomuk/Query/Term PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/CMakeLists.txt 1044143 
>   trunk/KDE/kdelibs/nepomuk/query/CMakeLists.txt PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/query/andterm.h PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/query/andterm.cpp PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/query/andterm_p.h PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/query/comparisonterm.h PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/query/comparisonterm.cpp PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/query/comparisonterm_p.h PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/query/dateparser.cpp PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/query/dateparser_p.h PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/query/dbusoperators.h PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/query/dbusoperators.cpp PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/query/filequery.h PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/query/filequery.cpp PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/query/groupterm.h PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/query/groupterm.cpp PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/query/groupterm_p.h PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/query/literalterm.h PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/query/literalterm.cpp PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/query/literalterm_p.h PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/query/negationterm.h PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/query/negationterm.cpp PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/query/negationterm_p.h PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/query/nepomukquery_export.h PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/query/nie.trig PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/query/org.kde.nepomuk.Query.xml PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/query/org.kde.nepomuk.QueryService.xml PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/query/orterm.h PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/query/orterm.cpp PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/query/orterm_p.h PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/query/query.h PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/query/query.cpp PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/query/query_p.h PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/query/querybuilderdata_p.h PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/query/queryparser.h PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/query/queryparser.cpp PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/query/queryserviceclient.h PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/query/queryserviceclient.cpp PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/query/resourceterm.h PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/query/resourceterm.cpp PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/query/resourceterm_p.h PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/query/result.h PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/query/result.cpp PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/query/simpleterm.h PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/query/simpleterm.cpp PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/query/simpleterm_p.h PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/query/term.h PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/query/term.cpp PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/query/term_p.h PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/query/test/CMakeLists.txt PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/query/test/pimo.trig PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/query/test/queryparsertest.h PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/query/test/queryparsertest.cpp PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/query/test/querytest.h PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/query/test/querytest.cpp PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/2061/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sebastian
> 
>

More information about the kde-core-devel mailing list