Review Request: startup faster; don't wait for kwin or kcm's in ksmserver

Sebastian Sauer mail at dipe.org
Sat Nov 7 14:46:51 GMT 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2034/
-----------------------------------------------------------

(Updated 2009-11-07 14:46:51.492620)


Review request for kdelibs.


Changes
-------

Updated patch to take Lubos feedback into account. Changes;
* Wait for the wm in autoStart1Done() to be sure the wm is there if apps are autostarted.
* Reverted the 'do no wait for initialization of kcm's' part. I'll look how to delay the init and kbuildsycoca later / with the next patch.


Summary
-------

* The fallback logic in wmProcessChange() does not work for kwin anyway cause kwin is the fallback. So, just don't wait and increase startup by 1/2 second for me.

* Waiting for the initialization of kcm's is not needed. Saves another 1/2 second.


Diffs (updated)
-----

  /trunk/KDE/kdebase/workspace/ksmserver/server.h 1045961 
  /trunk/KDE/kdebase/workspace/ksmserver/startup.cpp 1045961 

Diff: http://reviewboard.kde.org/r/2034/diff


Testing
-------


Thanks,

Sebastian





More information about the kde-core-devel mailing list