Review Request: Add method addGroundingOccurrence to Nepomuk::Thing.

Sebastian Trueg trueg at kde.org
Sat Nov 7 09:53:38 GMT 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2089/#review2968
-----------------------------------------------------------



/trunk/KDE/kdelibs/nepomuk/core/thing.cpp
<http://reviewboard.kde.org/r/2089/#comment2427>

    Either use setProperty here or use addProperty( go, res ) instead of rea-adding the whole list.
    
    The way you do it it will still work as ResourceData throws out duplicates but it is additional work.


- Sebastian


On 2009-11-07 09:44:05, George Goldberg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2089/
> -----------------------------------------------------------
> 
> (Updated 2009-11-07 09:44:05)
> 
> 
> Review request for kdelibs and Sebastian Trueg.
> 
> 
> Summary
> -------
> 
> Adds a method to Nepomuk::Thing that makes it possible to add a grounding occurrence of a thing more conveniently.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/nepomuk/core/thing.h 1045329 
>   /trunk/KDE/kdelibs/nepomuk/core/thing.cpp 1045329 
> 
> Diff: http://reviewboard.kde.org/r/2089/diff
> 
> 
> Testing
> -------
> 
> Tested in the app I'm working on at the moment, and seems to work fine. This is not a very intrusive change, so shouldn't introduce any other problems (I hope).
> 
> 
> Thanks,
> 
> George
> 
>





More information about the kde-core-devel mailing list