Review Request: startup faster; don't wait for kwin or kcm's in ksmserver

[Sebastian Sauer]

> On 2009-11-04 10:10:06, Lubos Lunak wrote:
> > I disagree with the first change and find the second one questionable. What are the specs of your machine and 1/2 second out of how many?
> > 
> > The reason for waiting for the WM to finish setup is not the fallback, but making sure the WM is ready. There are some aspects related to window management where applications just read the status during their startup and don't update later. So waiting for the WM ensures this is set up properly before other applications may read that (although, thinking of that, this is currently a bit broken anyway, as KWin lets ksmserver continue a bit too soon).
> > 
> > The second case is something similar. The kcminit modules do various setup and it is a question if it is ok to let normal apps start while this is still taking place.
> >

Specs are relative. Cold start (not initial) takes up to 9 seconds till the plasma desktop is visible / ksplashx closes.

The thing is that the wm starts very early. Even before plasma which does not need the wm at this point. The first "real" applications are rather late started/restored. Maybe we should just wait in KSMServer::autoStart1Done() till the wm is ready? Would that be enough?

The kde startup process has lot of potential for optimizations. Time expensive things like e.g. kcminit are atm blocking the whole startup. Long term we need to have expensive things run in parallel at startup. Anyway, if you think that this is not a good idea then it should be maybe done another way.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2034/#review2922
-----------------------------------------------------------


On 2009-11-03 10:31:32, Sebastian Sauer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2034/
> -----------------------------------------------------------
> 
> (Updated 2009-11-03 10:31:32)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> * The fallback logic in wmProcessChange() does not work for kwin anyway cause kwin is the fallback. So, just don't wait and increase startup by 1/2 second for me.
> 
> * Waiting for the initialization of kcm's is not needed. Saves another 1/2 second.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/ksmserver/server.h 1044052 
>   /trunk/KDE/kdebase/workspace/ksmserver/startup.cpp 1044052 
> 
> Diff: http://reviewboard.kde.org/r/2034/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sebastian
> 
>