Review Request: improved, Solid-based network error handling

[Marcus Harrison]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1933/
-----------------------------------------------------------

(Updated 2009-11-05 21:41:45.820010)


Review request for kdelibs.


Summary
-------

Adds Solid integration into basic network error-handling. This implementation should be applied across all applications that use standard error-handling messages, but I think it might be more proper for Solid to be integrated at the individual back-ends (for example, automatically disconnecting from online services and sending a message to the application a la Kopete).

This is my first patch, so feedback is welcomed and appreciated.


Diffs (updated)
-----

  trunk/KDE/kdelibs/kio/kio/global.cpp 1044591 

Diff: http://reviewboard.kde.org/r/1933/diff


Testing
-------

The only testing I have been able to do is to see whether this compiles properly - which it does. I have not been able to build kdebase/any individual applications against it recently, which is what I plan to do.


Thanks,

Marcus