Review Request: css unitialized variables

Maksim Orlovich maksim.orlovich at kdemail.net
Thu Nov 5 19:31:02 GMT 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2025/#review2941
-----------------------------------------------------------

Ship it!


This is fine, though the initialization clears warnings only -- the variables are passed to out-parameters..

- Maksim


On 2009-10-31 10:10:12, Jaime Torres wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2025/
> -----------------------------------------------------------
> 
> (Updated 2009-10-31 10:10:12)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> replace a C-style cast by a const_cast
> delete a check for null for delete
> initialize 3 uninitialized variables
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/khtml/css/css_base.cpp 1042787 
>   /trunk/KDE/kdelibs/khtml/css/css_mediaquery.cpp 1042787 
>   /trunk/KDE/kdelibs/khtml/css/cssstyleselector.cpp 1042787 
> 
> Diff: http://reviewboard.kde.org/r/2025/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jaime
> 
>





More information about the kde-core-devel mailing list