Qt KDE integration in kdereview.

[Olivier Goffart]

Le Wednesday 04 November 2009, Albert Astals Cid a écrit :
> The license says the file belongs to Nokia while it includes code taken
>  from kfiledialog.cpp

Right, i'll see what i need to do for the licence.

> The list variable in qt2KdeFilter and kde2QtFilter should be declared const

Fixed.

>  so the real const begin() and end() are called on it otherwise will
>  probably fail to compile when specifying strict iterators.

Explicit conversion is allowed.   Comparison and implicit conversion doesn't 
work when working with strict iterators.


> One question, how does it decide if it should use the KDE integration or
>  the GTK one?

We have some heuristics based on the running window manager, and the 
$DESKTOP_SESSION environement variable, and some X atoms.

Basicly, Qt detect KDE if KWin is the window manager, or $DESKTOP_SESSION == 
kde or kde4 

There is more magic.  the code is in qt_init() function in 
qapplication_x11.cpp

This is not perfect but seems to work.


> It's nice that Nokia cares about KDE :-)
> 
> Albert
>