[PATCH] Add WebDav REPORT query to KIO

David Faure faure at kde.org
Wed Nov 4 00:00:55 GMT 2009


On Tuesday 03 November 2009, Grégory Oestreicher wrote:
> Hi,
> 
> Le mardi 03 novembre 2009 19:58:04, David Faure a écrit :
> > - missing @since 4.4 in the new public davReport method
> 
> Fixed.
> 
> > - why take a QDomDocument? This prevents any other means of
> > creating XML, like QXMLStreamWriter, or having it in memory by any
> > other means. I suggest taking a QString as parameter instead, it's easy
> > enough for the QDomDocument users to call toString().
> 
> The QDomDocument is the type used for davPropfind, that I used as a basis
>  for davReport, and I didn't thought about other ways to create the XML
>  query.

Yeah, those other ways (at least QXmlStreamWriter) didn't exist when these
methods were created. So let's use QString in new methods, and we can always
add overloads to the existing methods later, when the need arises for non-
QDomDocument usage.

> Attached is the updated patch.

Looks good to me, please apply.

-- 
David Faure, faure at kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).




More information about the kde-core-devel mailing list