Review Request: Patch to show SHA1 sum for certs in KDE SSL Information window

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2035/#review2910
-----------------------------------------------------------

Ship it!


Looks ok, except for the unnecessary sample value.


/trunk/KDE/kdelibs/kio/kssl/sslinfo.ui
<http://reviewboard.kde.org/r/2035/#comment2317>

    Why the sample value here? It just seems to increase the risk of being displayed if the code ever forgets to setText on the label.


- David


On 2009-11-02 02:18:44, Tim Brown wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2035/
> -----------------------------------------------------------
> 
> (Updated 2009-11-02 02:18:44)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Konqueror only does not display the SHA1 sum for the cert in the KDE SSL Information window.  MD5 is broken and subject to chosen prefix attacks.  The supplied patch displays the SHA1 sum.
> 
> 
> This addresses bug 204849.
>     https://bugs.kde.org/show_bug.cgi?id=204849
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kio/kssl/ksslinfodialog.cpp 1042515 
>   /trunk/KDE/kdelibs/kio/kssl/sslinfo.ui 1042515 
> 
> Diff: http://reviewboard.kde.org/r/2035/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tim
> 
>