Review Request: startup faster; don't wait for kwin or kcm's in ksmserver

[Sebastian Sauer]

> On 2009-11-01 19:32:04, Michael Pyne wrote:
> > /trunk/KDE/kdebase/workspace/ksmserver/startup.cpp, line 162
> > <http://reviewboard.kde.org/r/2034/diff/2/?file=13608#file13608line162>
> >
> >     Weren't these 2 connections just established on line 152?

true, fixed.


> On 2009-11-01 19:32:04, Michael Pyne wrote:
> > /trunk/KDE/kdebase/workspace/ksmserver/startup.cpp, line 219
> > <http://reviewboard.kde.org/r/2034/diff/2/?file=13608#file13608line219>
> >
> >     Why leave this commented out if we're not doing this anymore?  We have SVN, I'd recommend removing it unless it's needed for understanding for someone coming across it later. (likewise with the line 2 below this).

fixed.


> On 2009-11-01 19:32:04, Michael Pyne wrote:
> > /trunk/KDE/kdebase/workspace/ksmserver/startup.cpp, line 234
> > <http://reviewboard.kde.org/r/2034/diff/2/?file=13608#file13608line234>
> >
> >     Was this connected anywhere else?  You removed the connection on line 211 (now 219) so it seems that you could remove this disconnect as well.

fixed.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2034/#review2890
-----------------------------------------------------------


On 2009-11-02 22:05:47, Sebastian Sauer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2034/
> -----------------------------------------------------------
> 
> (Updated 2009-11-02 22:05:47)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> * The fallback logic in wmProcessChange() does not work for kwin anyway cause kwin is the fallback. So, just don't wait and increase startup by 1/2 second for me.
> 
> * Waiting for the initialization of kcm's is not needed. Saves another 1/2 second.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/ksmserver/server.h 1042693 
>   /trunk/KDE/kdebase/workspace/ksmserver/startup.cpp 1042693 
> 
> Diff: http://reviewboard.kde.org/r/2034/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sebastian
> 
>