Review Request: KTimeZoneWidget bug
Aaron Seigo
aseigo at kde.org
Fri May 29 18:12:44 BST 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/772/#review1228
-----------------------------------------------------------
Ship it!
minor ws issue, but the logic looks good. :)
trunk/KDE/kdelibs/kdeui/widgets/ktimezonewidget.cpp
<http://reviewboard.kde.org/r/772/#comment763>
kdelibs coding style:
if (singleSelection {
clearSelection();
}
same for similar bock below on line 171
- Aaron
On 2009-05-27 01:48:25, Stanislas Marquis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/772/
> -----------------------------------------------------------
>
> (Updated 2009-05-27 01:48:25)
>
>
> Review request for kdelibs.
>
>
> Summary
> -------
>
> The KTimeZoneWidget can end up with more than one selected row when using setSelected while the widget is in SingleSelection mode.
>
>
> Diffs
> -----
>
> trunk/KDE/kdelibs/kdeui/widgets/ktimezonewidget.cpp 973438
>
> Diff: http://reviewboard.kde.org/r/772/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Stanislas
>
>
More information about the kde-core-devel
mailing list