Re-add .desktop file custom icons [PATCH]

[David Faure]

On Friday 29 May 2009, Michael Pyne wrote:
> So I've thought about it a bit more and decided it would probably be a better 
> idea to leave the custom icon but simply denote that there is something 
> possibly fishy about it.  We already have "emblem" infrastructure for just this 
> kind of thing, so the following patch converts the untrusted custom icon case 
> into a untrusted emblem case.  Note the reason we don't want to show custom 
> icons is to avoid maliciously downloaded .desktop files from showing some 
> innocuous icon (such as the image/jpeg icon) even though the .desktop file is 
> executable.

Sounds good to me.

>  [...]

> The other comment I have is that emblems don't work at all when file previews 
> are present for the specific file type, so if you don't see it, ensure that 
> you've turned off previews.

Sounds like a missing feature - we should show the emblem on top of the
preview too. No idea how, though :-))

-- 
David Faure, faure at kde.org, sponsored by Qt Software @ Nokia to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).