KConfigIniBackend::stringToPrintable optimization patch

Oswald Buddenhagen ossi at kde.org
Fri May 29 12:57:54 BST 2009


On Fri, May 29, 2009 at 12:07:40PM +0200, Frank Osterfeld wrote:
> On Friday 29 May 2009 11:33:15 Oswald Buddenhagen wrote:
> > anyway, that whole argumentation makes no sense unless you completely
> > forbid char *foo, bar, **baz;
> > style declarations. while i agree that using this c[++] feature is not
> > so nice in declarations of class members and global objects (both of
> > which should have expressive names), i'll readily laugh in the face of
> > anyone who tells me not to use "char c, *cp;" or the like in a function
> > with 10 lines.
> 
> Personally I wouldn't sacrifice readibility of ~99.5%ish of all pointer 
> occurrences for consistency with the other ~0.5%. How often do you actually 
> see "char c, *cp" etc. in Qt/KDE code?
> 
that doesn't matter. i use "char c, *cp", therefore i use
"char *buffer_pointer;", therfore i use "char *m_mainWindow;".
and i don't consider it a sacrifice. i read the code like the language
is defined, and i *like* it that way.




More information about the kde-core-devel mailing list