Review Request: Do not fetch metaInfo on special files (fifo/chr/blk), on the Properties file dialog

[Darío Andrés]

> On 2009-05-24 13:30:20, Christoph Feck wrote:
> > I am not sure, but are the macros you use available on all platforms? Maybe you should have an #ifdef here. Also, there is trailing white space (this diff viewer marks it red).
> 
> Darío Andrés wrote:
>     I don't know .. I just borrowed that functions from KFind code... I will investigate

Just searched:

http://lxr.oss.org.cn/ident?i=S_ISFIFO
And on Windows: http://lxr.kde.org/source/qt-copy/src/corelib/io/qfsfileengine.cpp#65
I don't know about the other platforms :\ but I guess it is a POSIX-related thing.


- Darío


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/723/#review1190
-----------------------------------------------------------


On 2009-05-19 14:08:11, Darío Andrés wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/723/
> -----------------------------------------------------------
> 
> (Updated 2009-05-19 14:08:11)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Check if the current file is a special file and in that case do not fetch the metaInfo as that will try to open the file and the application will hang
> 
> I wonder if this should be done inside KFileMetaInfo to avoid all the possible cases.., but doing it there will need to create a new KFileItem, fetch the mode and check it. (or may be doing it into: "KFileItem::metaInfo", but this may need to somehow "cache" the "non-possible-to-fetchmetainfo" response). To Discuss...
> 
> 
> This addresses bug 190596.
>     https://bugs.kde.org/show_bug.cgi?id=190596
> 
> 
> Diffs
> -----
> 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kio/kfile/kmetaprops.cpp 969788 
> 
> Diff: http://reviewboard.kde.org/r/723/diff
> 
> 
> Testing
> -------
> 
> The fix works OK. 
> 
> 
> Thanks,
> 
> Darío
> 
>