[PATCH] Priority of Solid Actions

Gökçen Eraslan gokcen at pardus.org.tr
Fri May 22 10:22:33 BST 2009


Hi,

I've hit a bug about action .desktop files of Solid and written a patch about 
this. When you install some applications with solid action desktop files (for 
example digikam), there is no mechanism for priority of those actions, I mean, 
when there are two desktop files with a matching predicate, the order of these 
actions in notification dialog is now undefined. Well actually, the order is 
defined like this:

KStandardDirs::findAllResources() -> lookupPrefix() -> lookupDictionary() -> 
readdir()

So, now, when hotplug data-engine determines the order of the action desktop 
files, it totally depends on readdir, which is different in different 
computers/disks.

Attached patch make comparisons based on InitialPreference key in desktop 
files, if it can't find any, it looks at the name of the desktop file (better 
than readdir order :) ). Maybe later, an option about ordering may be added to 
"Device Actions" kcm. 

Any ideas, comments?

-- 
Gökçen Eraslan
Pardus Developer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: solid-actions-priority.diff
Type: text/x-patch
Size: 3234 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20090522/35916213/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20090522/35916213/attachment.sig>


More information about the kde-core-devel mailing list