New System Settings

[Ben Cooksley]

On 5/22/09, dantti85-dev at yahoo.com.br <dantti85-dev at yahoo.com.br> wrote:
>
> Hi,
Hi Daniel,

> recently when the rewrite of system settings became
> the default one, PolicyKit Authorizations module got a
> crash, as that still might be the module fault i was not
> convinced that the coincidence of a new system settings
> had nothing to do with it. So putting some kDebugs here and
> there i found out that the module constructor is called each
> time i click in the PolicyKit entry(in the new version). Michael
Correct, the old system settings kept the module loaded and
instantiated which wasn't as efficient, and meant that the modules
state might not have looked correct when they reopened it. It also
prevented the user from opening a previously opened module after
switching views.

It was likely this that prevented the crash before.

> Jansen on #kde-devel agreed with me that calling the
> constructor again is bad. And since it does not unload the plugin.
All I do is create and destroy the KCModuleProxy, which ensures the
modules destructor is called ( It should anyway... )
Please see ModuleView::closeModules in systemsettings/core/ModuleView.cpp
I'm not sure how I can "unload" the plugin.

> So is this a valid issue against the new system settings
> or i still should try to catch this bug in the kcm module?
None of the other modules are affected, so the bug is likely in the KCM.

>
> Thanks,
> Daniel.
>
>
>       Veja quais são os assuntos do momento no Yahoo! +Buscados
> http://br.maisbuscados.yahoo.com
>

Regards,
Ben.