Review Request: Do not fetch metaInfo on special files (fifo/chr/blk), on the Properties file dialog

[Darío Andrés]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/723/
-----------------------------------------------------------

(Updated 2009-05-19 14:08:11.435521)


Review request for kdelibs.


Summary (updated)
-------

Check if the current file is a special file and in that case do not fetch the metaInfo as that will try to open the file and the application will hang

I wonder if this should be done inside KFileMetaInfo to avoid all the possible cases.., but doing it there will need to create a new KFileItem, fetch the mode and check it. (or may be doing it into: "KFileItem::metaInfo", but this may need to somehow "cache" the "non-possible-to-fetchmetainfo" response). To Discuss...


This addresses bug 190596.
    https://bugs.kde.org/show_bug.cgi?id=190596


Diffs
-----

  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kio/kfile/kmetaprops.cpp 969788 

Diff: http://reviewboard.kde.org/r/723/diff


Testing
-------

The fix works OK. 


Thanks,

Darío