Review Request: Fix translation of place names in Dolphin and other KFilePlacesView locations

[Peter Penz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/697/#review1152
-----------------------------------------------------------

Ship it!


Thanks for the patch, please commit :-)

- Peter


On 2009-05-13 09:19:09, Andrew Coles wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/697/
> -----------------------------------------------------------
> 
> (Updated 2009-05-13 09:19:09)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> System bookmark names are created with untranslated and translated names.  The untranslated name is discarded, and the displayed name is later obtained using i18n - but due to the lack of context, this isn't guaranteed to match the intended translated string.  
> 
> Solution: standardise on 'KFile System Bookmarks' as the context for localising system bookmark names.  So
>   
>   KFilePlacesItem::createSystemBookmark(d->bookmarkManager, "Home", i18nc("Home Directory","Home"), ...
>   ...
>   i18n(m_text)
> 
> ... becomes:
> 
>   KFilePlacesItem::createSystemBookmark(d->bookmarkManager, "Home", i18nc("KFile System Bookmarks","Home"), ...
>   ...
>   i18nc("KFile System Bookmarks",m_text)
> 
> Fixes the bug reported by annma, where losing the 'Home Directory' context of the initial i18nc call meant the French name of the Home key was being returned instead of the French name of the Home location.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kfile/kfileplacesitem.cpp 967400 
>   /trunk/KDE/kdelibs/kfile/kfileplacesmodel.cpp 967400 
> 
> Diff: http://reviewboard.kde.org/r/697/diff
> 
> 
> Testing
> -------
> 
> i) Fixes the bug in French (subject to the context strings in .po files being updated).
> ii) Creating a dummy translation, changing each KDE translation of "Home" to something else confirms the correct one is being picked up.  Before, it was picking up the translation of "Home" from kdeqt.po - now it gets the appropriate one from kio4.po.
> 
> 
> Thanks,
> 
> Andrew
> 
>