Review Request: Support for non-Western Arabic digits in numbers

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/666/#review1051
-----------------------------------------------------------

Ship it!


Seems good

- Albert


On 2009-05-03 17:58:40, Chusslove Illich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/666/
> -----------------------------------------------------------
> 
> (Updated 2009-05-03 17:58:40)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> There are several bugs related to Arabic-Indic digits not being supported for display and input. The attached patch should fix this:
> 
> 1) For input, since all digit characters are distinct Unicode points, a number written in any of defined digit sets is recognized irrespective of the locale settings. (It would be superb if this could be done with numbers in general, but it becomes ambiguous when it comes to thousand/decimal separators, so these have to be parsed according to locale.)
> 
> 2) For display, there are two new locale settings, DigitSet and MonetaryDigitSet, so that display can differ for the general and monetary values (just like with other number format settings). These are supported in straightforward fashion in locale control module (see screenshots).
> 
> 3) Aside from Arabic-Indic digits which are used in eastern Arabic dialects, I've also added Eastern Arabic-Indic digits used in Persian and Urdu, and Devenegari digits used in Hindu. Wikipedia states a lot more, but for any additional digit set I'd wait a user to request it.
> 
> (Of course, this would go in as two separate patches.)
> 
> 
> This addresses bugs 79862, 131365 and 178149.
>     https://bugs.kde.org/show_bug.cgi?id=79862
>     https://bugs.kde.org/show_bug.cgi?id=131365
>     https://bugs.kde.org/show_bug.cgi?id=178149
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/runtime/kcontrol/locale/localemon.cpp 961817 
>   trunk/KDE/kdebase/runtime/kcontrol/locale/localemon.h 961817 
>   trunk/KDE/kdebase/runtime/kcontrol/locale/localemon.ui 961817 
>   trunk/KDE/kdebase/runtime/kcontrol/locale/localenum.h 961817 
>   trunk/KDE/kdebase/runtime/kcontrol/locale/localenum.cpp 961817 
>   trunk/KDE/kdelibs/kdecore/localization/klocale.h 961864 
>   trunk/KDE/kdelibs/kdecore/localization/klocale.cpp 962162 
> 
> Diff: http://reviewboard.kde.org/r/666/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Non-Western Arabic numbers selection.
>   http://reviewboard.kde.org/r/666/s/116/
> 
> 
> Thanks,
> 
> Chusslove
> 
>