Review Request: KFilePlacesModel: Translate system bookmarks dynamically
Peter Penz
peter.penz at gmx.at
Fri May 1 21:41:46 BST 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/650/
-----------------------------------------------------------
Review request for kdelibs.
Summary
-------
The patch fixes the issue that system bookmarks like "Home", "Root", "Network" and "Trash" are not retranslated if the user changes the language.
Root cause of the issue:
The system bookmarks are only translated once after the first access to the bookmarks. Afterwards the bookmark labels are handled as "normal" text.
Solution:
The bookmarks are stored untranslated in the model and get translated dynamically for the user interface when the list view requests the label. For sure it is still possible that the user changes the label of a system bookmark.
If there are no objections/comments, I'll commit the patch on May the 5th.
This addresses bug https://bugs.kde.org/show_bug.cgi?id=177536.
https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=177536
Diffs
-----
kdelibs/kfile/kfileplacesmodel.cpp 961249
Diff: http://reviewboard.kde.org/r/650/diff
Testing
-------
Thanks,
Peter
More information about the kde-core-devel
mailing list