Review Request: Adding a SolidBackendChooser Widget to KDEUI

[Andreas Pakulat]

> On 2009-03-30 02:34:18, Andreas Pakulat wrote:
> > So which applications would use this widget, besides the solid kcm's (I'm assuming the kcm's can share the widget without it being in kdelibs)?
> 
> Dario Freddi wrote:
>     At the moment none, but since Solid is growing, some applications could (in the future) provide a backend selector directly in their configuration panel. And it allows a single entry point to let the user modify backends in a consistent way. Since it's not a big overhead to kdeui, I think putting it there could be a sensible decision
> 
> Oswald Buddenhagen wrote:
>     i hate to spoil the party ... but the 2+ users requirement exists not only to keep useless stuff out of the libs, but also to ensure API quality. as such, it would make sense if you ported any potential users to that api before pushing it.
> 
> Dario Freddi wrote:
>     Ok, so basically you suggest to import this after the KCMs will be refactored? If so, I'll wait until then, I just wanted to know if, known the fact that the current hardware module will be splitted into the relevant modules (Power Management, Networking, etc), so definitely 2+ users, this patch should go in. Making the widget shared between the various kcms would be an unneeded overhead in my opinion

We suggest that there should be at least 2 different users of this widget before it goes into kdelibs. And I'm not sure wether multiple kcm's living in the same place in svn counts as multiple users of the class. The reason to move it to kdelibs should be that apps that cannot easily share such classes because they're in different modules don't have to keep their own copy. And a couple of kcm's inside kdebase can share the code by simply having that class in a common directory and each kcm compiling it into the plugin.


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/475/#review718
-----------------------------------------------------------


On 2009-03-30 02:27:57, Dario Freddi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/475/
> -----------------------------------------------------------
> 
> (Updated 2009-03-30 02:27:57)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This patch adds a new widget to KDEUI, SolidBackendChooser. It is nothing but the widget now present in the Hardware KCM, updated with API Docs, a slightly better API and with all the nice things to help Binary Compatibility. It will be used for the refactoring of the new Solid kcmodules
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdeui/CMakeLists.txt 946126 
>   /trunk/KDE/kdelibs/kdeui/widgets/solidbackendchooser.h PRE-CREATION 
>   /trunk/KDE/kdelibs/kdeui/widgets/solidbackendchooser.cpp PRE-CREATION 
>   /trunk/KDE/kdelibs/kdeui/widgets/solidbackendchooser.ui PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/475/diff
> 
> 
> Testing
> -------
> 
> Works in my copy
> 
> 
> Thanks,
> 
> Dario
> 
>