Updating the minimal required version number for kdelibs, inside kdebase
apaku at gmx.de
Mon Mar 30 13:03:28 BST 2009
On 30.03.09 12:44:49, Shlomi Fish wrote:
> On Sun, Mar 29, 2009 at 11:11 PM, Andreas Pakulat <apaku at gmx.de> wrote:
> > On 29.03.09 21:13:30, Shlomi Fish wrote:
> >> The attached patch adds a minimal required version number of kdelibs
> > This is not quite the right list for patches, you should send such a patch to
> > kde-core-devel next time (AFAIK). I'm cc'ing them.
> Yes, but I was told to address release-team because you are the ones
> who should update the version in kdebase.
Ok, I'm moving the technical part of the discussion to kde-core-devel
completely as thats where it belongs.
> >> Index: CMakeLists.txt
> >> ===================================================================
> >> --- CMakeLists.txt (revision 946568)
> >> +++ CMakeLists.txt (working copy)
> >> @@ -13,7 +13,7 @@
> >> #
> >> # search packages used by KDE
> >> -find_package(KDE4 REQUIRED)
> >> +find_package(KDE4 4.2.68 REQUIRED)
> > I guess the reason for the find_packages in runtime/workspace/apps is for
> > the split-built thats supported. If that is the case I don't see why a
> > find_package is needed in the top-level file at all. And the following
> > calls should be moved down to the three subdirs. (I know thats unrelated to
> > your actual patch).
> I tried removing the find_package call altogether from the root
> CMakeLists.txt file, but then the includes afterwards failed.
Yes, of course you'll have to remove the stuff that references any kde4
variables as well, but as far as I understood it the top-level
CMakeLists.txt should just have 3 add_subdirectory() calls anyway.
Anyway, thats not really a change that belongs into your patch, so the
above part of the change is ok.
Your step will soil many countries.
More information about the kde-core-devel